feat: implement when/then/otherwise for DuckDB #1759
Merged
+126
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
duckdb-when
branch
from
4e9ec8b to
89c8b1e
Compare
MarcoGorelli
force-pushed
the
duckdb-when
branch
from
84f3296 to
8b663da
Compare
MarcoGorelli
commented
Jan 7, 2025
tpch/execute.py
Outdated
| "dask": lambda x: x.compute(), | ||
| } | ||
|
|
||
| DUCKDB_XFAILS = [11, 14, 15, 16, 18, 22] |
There was a problem hiding this comment.
16 out of the 22 queries already work with duckdb 😱
EdAbati
approved these changes
Jan 7, 2025
| @@ -157,6 +158,16 @@ def func(df: DuckDBLazyFrame) -> list[duckdb.Expression]: | |||
| kwargs={"exprs": exprs}, | |||
| ) | |||
|
|
|||
| def when( | |||
| self, | |||
| *predicates: IntoDuckDBExpr, | |||
There was a problem hiding this comment.
Suggested change
| *predicates: IntoDuckDBExpr, | |
| *predicates: IntoDuckDBExpr |
trailing comma 😱 (just joking. I love the other PRs 😅)
There was a problem hiding this comment.
ok this made me laugh out loud 😆
| *predicates: IntoDuckDBExpr, | ||
| ) -> DuckDBWhen: | ||
| plx = self.__class__(backend_version=self._backend_version, version=self._version) | ||
| condition = plx.all_horizontal(*predicates) |
There was a problem hiding this comment.
Suggested change
| condition = plx.all_horizontal(*predicates) | |
| if predicates: | |
| condition = plx.all_horizontal(*predicates) | |
| else: | |
| msg = "at least one predicate needs to be provided" | |
| raise TypeError(msg) |
The other backends have this check
There was a problem hiding this comment.
ah i moved it up cause i was tired of rewriting it everywhere 😄 #1756
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finally i make a useful today
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below